fix: update urllib3 and sphinx dependencies to address vulnerabilities#112
Merged
Conversation
javihern98
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump urllib3 from 2.6.3 to 2.7.0 to address a security advisory in the older version. urllib3 is pulled in transitively via
sphinx → requests → urllib3inthe
docsgroup. The sphinx constraint is widened so the resolver can pick up a newer urllib3.Type of Change
Related Issues
Closes #
Related to #
Changes Made
sphinxconstraint inpyproject.tomlfrom^7.4.7to>=7.4.7,<8.2(8.2+ requires Python 3.11+, which would drop our supported 3.10).sphinx7.4.7 → 8.1.3 andurllib32.6.3 → 2.7.0 via targetedpoetry update --lock sphinx urllib3. No other packages touched.Testing
Tests Added
Testing Performed
Test results:
-Wwith sphinx 8.1.3)Documentation
### Securityentry — not done in this PR)Code Quality
ruff checkandruff formatmypytype checkingBreaking Changes
N/A —
urllib3andsphinxare docs-group dependencies only and are not exposed to end users. End users installingeba-xbridgefrom PyPI get only theruntime
dependencies(pandas, lxml, numpy); poetry groups are not published as extras.Impact: None for end users. Contributors who run
poetry install --with docswill get sphinx 8.1.3 and urllib3 2.7.0.Migration guide: N/A.
Screenshots (if applicable)
N/A
Checklist
Additional Notes
A blanket
poetry update --lockwould have churned ~25 packages; usingpoetry update --lock sphinx urllib3keeps the lock-file diff to exactly the twointended bumps (17 insertions, 17 deletions in
poetry.lock).sphinx was capped at
<8.2to preserve Python 3.10 support: sphinx 8.2+ requires Python>=3.11, sphinx 9.x requires>=3.12.Reviewer Notes
Areas to focus on:
<8.2is acceptable, or if we'd rather drop Python 3.10 support and go higher.### Securityentry under[Unreleased]should be added before merge.Questions for reviewers:
main-only fine given the dep is docs-only?