feat(formatter): improve Watcom SQL formatting rules#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves SQLovely’s Watcom SQL formatter and syntax support with a broad set of formatting, metadata, highlighting, and safety fixes.
Changes
IF ... THEN ... END IFstatements.UNION ALLon separate lines.IF ... THEN ... ELSE ... ENDIFexpressions.SELECT,FROM,WHERE,JOIN,ON,ORDER BY, and related continuations.FOR ... CURSOR FOR ... DO ... END FORloops.CASE ... WHEN ... THEN ... ELSE ... ENDexpressions."isnull"(,"string"(, and"date"(.ELSEIFbranch indentation.ORDER BYIF-expression separators.Notes
This PR is focused on stabilizing formatter behavior for real Watcom SQL exports and generated database scripts. It also adds safeguards to avoid running expensive formatting passes on very large SQL documents.
Testing