Skip to content

Gbrunin/analyzer refactoring#4

Open
gbrunin wants to merge 50 commits into
mainfrom
gbrunin/analyzer_refactoring
Open

Gbrunin/analyzer refactoring#4
gbrunin wants to merge 50 commits into
mainfrom
gbrunin/analyzer_refactoring

Conversation

@gbrunin

@gbrunin gbrunin commented Jun 11, 2026

Copy link
Copy Markdown
Member

No description provided.

gbrunin and others added 30 commits June 4, 2026 14:28
… over batches of frames, that will be used to choose between a frame-by-frame analysis, batch-of-frames by batch-of-frames, or a concatenation of the whole trajectory.
…vapor. This interface will be used to fit a circle or sphere, for slices or as a surface on the whole drop shape.
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.41466% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.81%. Comparing base (3e2525a) to head (897cc7e).

Files with missing lines Patch % Lines
...angle_kit/visualization/density_contour_plotter.py 65.60% 43 Missing ⚠️
src/wetting_angle_kit/analysis/interface/_grid.py 89.04% 16 Missing ⚠️
src/wetting_angle_kit/analysis/_base.py 89.47% 14 Missing ⚠️
.../wetting_angle_kit/analysis/coupled_fit/_models.py 91.86% 7 Missing ⚠️
src/wetting_angle_kit/analysis/interface/_rays.py 94.28% 6 Missing ⚠️
src/wetting_angle_kit/analysis/_density.py 95.23% 5 Missing ⚠️
src/wetting_angle_kit/analysis/fitters/_whole.py 92.06% 5 Missing ⚠️
...ting_angle_kit/analysis/coupled_fit/analyzer_2d.py 93.54% 4 Missing ⚠️
...ting_angle_kit/analysis/coupled_fit/analyzer_3d.py 93.10% 4 Missing ⚠️
src/wetting_angle_kit/analysis/fitters/_taubin.py 92.50% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   90.22%   90.81%   +0.58%     
==========================================
  Files          26       38      +12     
  Lines        1279     2133     +854     
==========================================
+ Hits         1154     1937     +783     
- Misses        125      196      +71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbrunin gbrunin requested a review from gtaillandier June 17, 2026 07:32
@gtaillandier

gtaillandier commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator
  • Error in the tutorial and example of Whole-Fit Contact Angle with Bootstrap, quik change replace the wall parser wall_detector=WallDetector.min_plus_offset()
  • For the batchresult, in the case of Slicing batch results, it would be interesting to have the median and the mean of the angles
  • had an error when slicing.analyze(range(0, 50)) is bigger than the number of frame, it leads to false results and wrong angle_evolution.html
  • error "zi_f": 40.0 i too small at least "zi_f": 60.0 in /wetting_angle_kit/docs/tutorials//coupled_fit_3d_tuto.md
  • Add in the example an example with CoupledFit3DAnalyzer

@gtaillandier

Copy link
Copy Markdown
Collaborator

Maybe add more explaination about : the bootstrap method in the theoretical section

@gtaillandier

gtaillandier commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

It would be nice to have a section in the tutorial dedicated to this ========================== =========================================
surface_kind, geometry required ray params
========================== =========================================
slicing, spherical delta_azimuthal (+ delta_polar)
slicing, cylinder_x/y delta_cylinder (+ delta_polar)
whole, spherical n_rays_sphere
whole, cylinder_x/y delta_cylinder (+ delta_polar)
========================== ========================================= Because when i did some trials i was struggling to understand which required ray params before looking carefully at the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants