Skip to content

fix (table): move <tbody> outside the loop#366

Open
jay8t6 wants to merge 1 commit into
masterfrom
tbody-fix
Open

fix (table): move <tbody> outside the loop#366
jay8t6 wants to merge 1 commit into
masterfrom
tbody-fix

Conversation

@jay8t6

@jay8t6 jay8t6 commented Jul 16, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@ryanis-online

Copy link
Copy Markdown

Running the update snapshots command should fix this build

FAILED TESTS:
 
  chameleon-table
 
    ✖ doesn't render pagination if .hidePagination is true
 
      HeadlessChrome 84.0.4147 (Linux 0.0.0)
 
    AssertionError: Received value does not match stored snapshot 0

@kewalter

Copy link
Copy Markdown
Contributor

I want to verify that this doesn't break the ability to hide/show detail rows. The tbody was used as a workaround, but I can't remember exactly why.

@chuckhousley chuckhousley removed their assignment Dec 3, 2020
@ZempTime ZempTime removed their assignment Feb 22, 2021
@terrencebowen terrencebowen removed their assignment Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants