Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

[WIP] Add ComparableMixin to InfraVMsCollection and add compare vms test utilizing the mixin.#10054

Open
prichard77 wants to merge 23 commits into
ManageIQ:masterfrom
prichard77:compareVMs
Open

[WIP] Add ComparableMixin to InfraVMsCollection and add compare vms test utilizing the mixin.#10054
prichard77 wants to merge 23 commits into
ManageIQ:masterfrom
prichard77:compareVMs

Conversation

@prichard77

@prichard77 prichard77 commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Purpose or Intent

  • __Adding tests__to utilize ComparableMixin for VM Collections.
    This contains commits from PR#9912

PRT Run

@dajoRH dajoRH added the WIP label Apr 15, 2020
@dajoRH

dajoRH commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

I detected some fixture changes in commit a02a91aa2affd1285621bffce94a2940445cca5d

The local fixture setup_provider_min_vms is used in the following files:

  • cfme/tests/infrastructure/test_vm_compare.py
    • test_compare_vms

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

@dajoRH

dajoRH commented Apr 15, 2020

Copy link
Copy Markdown
Contributor

Lint report for commit a02a91aa2affd1285621bffce94a2940445cca5d:

cfme/tests/infrastructure/test_providers.py:

  • ‼️ Line 535:1: E302 expected 2 blank lines, found 1

Please, rectify these issues 😏 .

No commit flaws detected.

CFME QE Bot

@dajoRH

dajoRH commented May 12, 2020

Copy link
Copy Markdown
Contributor

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants