Repository navigation
Conversation
… and layered model - add creator_id/updater_id to metric_info; replace unique key uk_datasource_metric_key with non-unique idx_datasource_metric_key so a soft-deleted key can be recreated (soft-deleted rows are no longer restored, kept for audit) - rewrite MetricInfoMapper as AuditableMapper<MetricInfoPo>; all single-table reads use LambdaQueryWrapper default methods (selectByKey/selectByDatasource/suggest) and delete the hand-written MetricInfoMapper.xml - introduce model.po/bo/vo/dto and MetricConverter (toPoForInsert/toPoForUpdate); remove legacy entity.MetricInfo, dto.MetricRequest/MetricResponse and convertor.MetricConverter - MetricService/Controller now work with BO/VO and BaseVo, list becomes IPage/BatchQueryVo pagination, dropping getByKey/listAll - frontend metric API/view adapt to pagination and split create/update request types - AGENTS.md: document Optional usage for internal nullable values; remove unused entity.UserSession
- Accept datasourceId from the client in create and page requests - Add MetricQueryDto with required datasourceId validation - Validate datasource existence on create - Pass the session datasource to getCaliberByHint instead of the unused active-datasource lookup in GetMetricCaliberTool - Remove activeDatasourceId() so the metric page no longer fails when no datasource is active - Add a datasource selector to MetricManage.vue and render an empty state without calling the API when no datasource exists
|
Thank you for your contribution! We will review your request as soon as possible. Please review the code yourself using ponytail https://github.com/DietrichGebert/ponytail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #169 related #155
datasourceId, andcreatechecks the datasource existsgetCaliberByHintinstead of the unused active datasource; removeactiveDatasourceId()MetricManage.vueAuditMetaObjectHandlersocreator_id/updater_id/timestamps are always writtenMetricInfoMapper; remove the hand-written XML mappermetric_infoschema: addcreator_id/updater_id, replace unique key with non-unique index