fix(facet): Honor facet size in draw!#770
Merged
Merged
Conversation
`draw!(fig, d; facet = (; size = FacetSize(...)))` errored because the `:size` key was never consumed: `_draw!` did not forward `facet` to `compute_axes_grid`, so the axis width/height were not applied, and the key leaked into `clean_facet_attributes` as an unsupported keyword. `Makie.plot!` now forwards `facet` to `compute_axes_grid` and `_draw!` strips `:size` before `facet!`, mirroring the non-mutating `draw` path. Also prepares the v0.12.13 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facet = (; size = FacetSize(...))worked withdrawbut errored withdraw!:_draw!never forwardedfacettocompute_axes_grid, so theFacetSizewas neither applied to the axis width/height nor used for the wrap layout, and the:sizekey leaked intoclean_facet_attributes. Nowplot!forwardsfacetand_draw!strips:sizebeforefacet!, mirroring the non-mutatingdrawpath.Also bumps the version to v0.12.13.