feat: add makepad landing proxy#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Nginx virtual host configuration to serve the Makepad landing site (makepad.fr) via the shared proxy stack, including production wiring (overlay network + deploy workflow).
Changes:
- Added a new
makepad.fr/www.makepad.frNginx site template with HTTP→HTTPS andwww→apex redirects plus upstream proxying. - Wired the new site into the base
compose.ymland production override network definitions. - Updated the manual deploy workflow and production env to include the new overlay network and site settings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sites/makepad-landing-prod.conf.template |
Adds new vhost(s) for makepad.fr proxying and www redirects, including ACME challenge handling. |
compose.yml |
Registers the new Nginx template config, env vars, and attaches the service to the new app network. |
envs/production/compose.yml |
Adds the new external overlay network mapping for production deploys. |
envs/production/.env.proxy |
Adds production hostnames, upstream, and TLS cert/key paths for the new site. |
.github/workflows/manual-deploy.yml |
Ensures the new network secret is required, bundled, and created before stack deploy. |
README.md |
Documents the new site/network and expected TLS cert paths (but currently misses the VIF network/secret in the lists). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.