Skip to content

feat: add makepad landing proxy#6

Merged
kaanyagci merged 3 commits into
mainfrom
codex/makepad-landing-proxy
Jun 12, 2026
Merged

feat: add makepad landing proxy#6
kaanyagci merged 3 commits into
mainfrom
codex/makepad-landing-proxy

Conversation

@kaanyagci

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Nginx virtual host configuration to serve the Makepad landing site (makepad.fr) via the shared proxy stack, including production wiring (overlay network + deploy workflow).

Changes:

  • Added a new makepad.fr / www.makepad.fr Nginx site template with HTTP→HTTPS and www→apex redirects plus upstream proxying.
  • Wired the new site into the base compose.yml and production override network definitions.
  • Updated the manual deploy workflow and production env to include the new overlay network and site settings.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sites/makepad-landing-prod.conf.template Adds new vhost(s) for makepad.fr proxying and www redirects, including ACME challenge handling.
compose.yml Registers the new Nginx template config, env vars, and attaches the service to the new app network.
envs/production/compose.yml Adds the new external overlay network mapping for production deploys.
envs/production/.env.proxy Adds production hostnames, upstream, and TLS cert/key paths for the new site.
.github/workflows/manual-deploy.yml Ensures the new network secret is required, bundled, and created before stack deploy.
README.md Documents the new site/network and expected TLS cert paths (but currently misses the VIF network/secret in the lists).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

@kaanyagci kaanyagci merged commit d48a369 into main Jun 12, 2026
1 check passed
@kaanyagci kaanyagci deleted the codex/makepad-landing-proxy branch June 12, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants