fix: Create a new HandConfig instance when config=None in HandCalculator.estimate_hand_value#271
Merged
Merged
Conversation
…lculator.estimate_hand_value`
Collaborator
Author
|
It might be a good idea to explicitly state in the docstring that the value of |
Nihisil
approved these changes
May 12, 2026
Contributor
Nihisil
left a comment
Nihisil
left a comment
There was a problem hiding this comment.
It is ok to fix this bug as is now, but I think later we should reconsider our approach here and config shouldn't be modified during hand calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
HandCalculator.estimate_hand_valueuses the module-level_DEFAULT_CONFIGwhenconfig=None.However, during hand calculation, the dora han count is updated dynamically.
Because
_DEFAULT_CONFIGis mutable, running the calculator in a multi-threaded environment can result in incorrect dora han counts.To avoid this issue, a new
HandConfiginstance is now created wheneverconfig=None.As a trade-off, the method becomes slightly slower.