Skip to content

fix: if task is older than children then rebuild #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchalamet merged 1 commit into from
Jun 14, 2025
Merged

fix: if task is older than children then rebuild #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Terrabuild/Core/Build.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,6 @@ let run (options: ConfigOptions.Options) (cache: Cache.ICache) (api: Contracts.I
Log.Debug("{NodeId} must rebuild because force requested", node.Id)
TaskRequest.Build, buildNode()

elif maxCompletionChildren = DateTime.MaxValue then
Log.Debug("{NodeId} must rebuild because child is rebuilding", node.Id)
TaskRequest.Build, buildNode()

elif node.Cache <> Terrabuild.Extensibility.Cacheability.Never then
let cacheEntryId = GraphDef.buildCacheKey node
match cache.TryGetSummaryOnly allowRemoteCache cacheEntryId with
Expand All @@ -276,6 +272,11 @@ let run (options: ConfigOptions.Options) (cache: Cache.ICache) (api: Contracts.I
Log.Debug("{NodeId} must rebuild because node is failed and retry requested", node.Id)
TaskRequest.Build, buildNode()

// task is older than children
elif summary.EndedAt <= maxCompletionChildren then
Log.Debug("{NodeId} must rebuild because child is rebuilding", node.Id)
TaskRequest.Build, buildNode()

// task is cached
else
Log.Debug("{NodeId} is marked as used", node.Id)
Expand Down