Skip to content

Fix IO benchmark storage setup and defer GPU detection #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SoraSuegami wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix IO benchmark storage setup and defer GPU detection #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/test_gpu_aky24_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,6 +987,7 @@ async fn build_naive_vec_encoding_bench_estimator(
bench_dir: PathBuf,
) -> NaiveBGGVecBenchEstimator<BggEncodingBenchEstimator<GpuMatrix>> {
ensure_clean_dir(&bench_dir);
init_storage_system(bench_dir.clone());

let (public_lut, public_lut_id, public_lut_gate_id) =
build_benchmark_public_lookup_gate(params);
Expand Down Expand Up @@ -1064,12 +1065,8 @@ async fn test_gpu_aky24_io_error_search_and_bench_estimate() {
.with(log_filter)
.with(tracing_subscriber::fmt::layer())
.try_init();
gpu_device_sync();

let cfg = Aky24IOGpuBenchConfig::from_env();
info!("AKY24IO GPU bench config: {:?}", cfg);
let gpu_id =
*detected_gpu_device_ids().first().expect("test_gpu_aky24_io requires at least one GPU");
let temp_dir = tempdir().expect("AKY24IO GPU bench test must create a tempdir");
init_storage_system(temp_dir.path().to_path_buf());

Expand Down Expand Up @@ -1170,6 +1167,9 @@ async fn test_gpu_aky24_io_error_search_and_bench_estimate() {
return;
}

gpu_device_sync();
let gpu_id =
*detected_gpu_device_ids().first().expect("test_gpu_aky24_io requires at least one GPU");
let (cpu_params, gpu_params) =
gpu_params_for_crt_depth(&cfg, selected.ring_dim, selected.crt_depth, gpu_id);
assert_eq!(
Expand Down
8 changes: 4 additions & 4 deletions tests/test_gpu_diamond_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,7 @@ async fn build_naive_vec_encoding_bench_estimator(
bench_dir: PathBuf,
) -> NaiveBGGVecBenchEstimator<BggEncodingBenchEstimator<GpuMatrix>> {
ensure_clean_dir(&bench_dir);
init_storage_system(bench_dir.clone());

let (public_lut, public_lut_id, public_lut_gate_id) =
build_benchmark_public_lookup_gate(params);
Expand Down Expand Up @@ -884,12 +885,8 @@ async fn test_gpu_diamond_io_error_search_and_bench_estimate() {
.with(log_filter)
.with(tracing_subscriber::fmt::layer())
.try_init();
gpu_device_sync();

let cfg = DiamondIOGpuBenchConfig::from_env();
info!("DiamondIO GPU bench config: {:?}", cfg);
let gpu_id =
*detected_gpu_device_ids().first().expect("test_gpu_diamond_io requires at least one GPU");
let temp_dir = tempdir().expect("DiamondIO GPU bench test must create a tempdir");
init_storage_system(temp_dir.path().to_path_buf());

Expand Down Expand Up @@ -989,6 +986,9 @@ async fn test_gpu_diamond_io_error_search_and_bench_estimate() {
return;
}

gpu_device_sync();
let gpu_id =
*detected_gpu_device_ids().first().expect("test_gpu_diamond_io requires at least one GPU");
let (cpu_params, gpu_params) =
gpu_params_for_crt_depth(&cfg, selected.ring_dim, selected.crt_depth, gpu_id);
assert_eq!(
Expand Down
Loading