Add implementation optim_jl based on Julia's package Optim.jl for the optim interface#868
Merged
Merged
Conversation
For some reason it worked before with using serialized buffer as a string, but somehow started to fail. By actually treating the data as bytes and using the correct buffer length, the deserialization now should stop where it should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaRDI Pull Request
Changes:
Optim.jlpackageoptim_jlimplementation for theoptiminterfacetest_optim.jlforoptim_jlOIFConfigDictthat was based on the traversing the serialized buffer as a string, instead of being treated as an array ofUInt8elements of the given length