Repository navigation
Container user - #2201
Merged
Merged
Container user#2201
Conversation
Since we made this Dockerfile, docker gained the ability to bring its own init, so remove explicit tini. Now that we control our deploy infrastructure we can explicitly run the fsweb user as uid 1000 without the custom entrypoint. Keep the entrypoint as a dev tool for use in shared servers where we want the uid to match your local user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we made this Dockerfile, docker gained the ability to bring its
own init, so remove explicit tini.
Now that we control our deploy infrastructure we can explicitly run the
fsweb user as uid 1000 without the custom entrypoint.
Keep the entrypoint as a dev tool for use in shared servers where we
want the uid to match your local user.
Deployment steps:
deploy in parallel with deploy repo changes for swarm