Convert string properties to char strings in python mask creator#638
Merged
Conversation
Collaborator
Author
TestingThis was tested as part of a workflow to create culled meshes in Polaris on Chrysalis. Without this fix, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, properties (e.g.
heightandhistory) for mask variables were being written out asstringfields. These work for NETCDF4 format but cannot be converted withncksto CDF format. Instead, we want to write them out as character strings in the same way that transect and region names are handled. This merge handles all fields that are strings in the same way, using the length of the longest string as the dimension of character fields. This retains compatibility withNETCDF3*formats.The mask creator has also been updated to use the desired ruff formatting and to use f-strings instead of format strings.