Skip to content

Feature: Add support for pandas 3#443

Merged
akeeste merged 13 commits into
MHKiT-Software:developfrom
simmsa:feat_add_pandas_3.0_support
Jun 9, 2026
Merged

Feature: Add support for pandas 3#443
akeeste merged 13 commits into
MHKiT-Software:developfrom
simmsa:feat_add_pandas_3.0_support

Conversation

@simmsa

@simmsa simmsa commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Pandas 3 Changes

  • Updated pandas dependency to allow versions >=2.2.2 without an upper limit in both environment-dev.yml and pyproject.toml, enabling support for pandas 3.x.
  • Added a new function replace_pandas_missing_values_with_nan in mhkit/wave/io/ndbc.py to replace missing values with NaN in a way that is compatible with both pandas 2.x and 3.x.

Test Updates

https://pandas.pydata.org/docs/user_guide/timeseries.html#period-aliases

@simmsa simmsa marked this pull request as draft June 8, 2026 14:36
@akeeste akeeste linked an issue Jun 8, 2026 that may be closed by this pull request
pyarrow provides native string dtype support for mhkit.

While technically optional, mhkit benefits from one standardized backend
for representing columnar data. At this time pyarrow is that standard.
simmsa added 6 commits June 8, 2026 17:22
The narrow hdf5 range causes the solve when pyarrow is included to be
slow. Increasing the allowed range improves the pip solver speed.
These should no longer be necessary with the changes to dependencies
This removes any explicit coveralls intalls in favor of the
coverallsapp/github-action@v2 which is self contained and contains all
binaries necessary for coveralls to run.
Agg is a non interactive matplotlib backend and lets the tests runh
"headless". Without this specification tests can choose their backend
which can sometimes lead to failing tests on headless machines (GH
        Actions).

@akeeste akeeste left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simmsa! This looks great. All the tests are passing. I think we can just clean up the edit to main.yml re the test matrix on this PR and merge

Comment thread .github/workflows/main.yml
@simmsa simmsa marked this pull request as ready for review June 9, 2026 18:13
@akeeste

akeeste commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

All tests passed on the last significant commit. Approved and merging.

@akeeste akeeste merged commit df4e431 into MHKiT-Software:develop Jun 9, 2026
80 of 113 checks passed
@simmsa

simmsa commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@akeeste, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function failing test: test_get_buoy_metadata

2 participants