Skip to content

Remove old#37

Merged
pkunz96 merged 15 commits into
mainfrom
remove_old
Aug 15, 2025
Merged

Remove old#37
pkunz96 merged 15 commits into
mainfrom
remove_old

Conversation

@pkunz96

@pkunz96 pkunz96 commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

The following changes were made:

  • Fixed wrong import of LLMService in fileextractlib.LectureLlmGenerator
  • Added dimensionality to config.yaml

ZiyaSelim
ZiyaSelim previously approved these changes Jul 31, 2025
@ZiyaSelim ZiyaSelim dismissed their stale review July 31, 2025 11:38

Found an error after testing more

@ZiyaSelim ZiyaSelim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin immernoch am testen ob das ganze system mit den änderungen überhaupt läuft.
Hab dabei schonmal die Fehler in den kommentaren gefunden.
Selbst mit fixes da tut es bei mir gerade aber wegen nem anderen Bug nicht

Comment thread config.yaml Outdated
Comment thread config.yaml Outdated
Comment thread config.yaml Outdated

@ZiyaSelim ZiyaSelim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkunz-at-pspace

Copy link
Copy Markdown

Done

@pkunz96 pkunz96 merged commit cb37de1 into main Aug 15, 2025
1 check passed
@pkunz96 pkunz96 deleted the remove_old branch August 15, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants