Skip to content

Bugfix: No longer sends multiple StudentCodeSubmittedEvents on page r…#21

Merged
MP-DG merged 7 commits into
mainfrom
bugfix-multiple-proactive-feedback
Jan 15, 2026
Merged

Bugfix: No longer sends multiple StudentCodeSubmittedEvents on page r…#21
MP-DG merged 7 commits into
mainfrom
bugfix-multiple-proactive-feedback

Conversation

@MP-DG

@MP-DG MP-DG commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Description of changes

No longer sends multiple StudentCodeSubmittedEvents when page is reloaded. Fixes the AI-tutor sending additional proactive feedback.

How has this been tested?

Please describe the test strategy you followed. If not tested, please explain why.

  • automated unit test
  • automated integration test
  • manual, exploratory test

Failing testcases are unrelated to my changes and also on main

Checklist before requesting a review

  • My code is easy to understand
  • My code follows the coding guidelines of this project
  • My code fulfills all acceptance criteria
  • The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
  • I have made corresponding changes to the documentation or
    the wiki/adr
  • I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

@MP-DG MP-DG requested a review from nk-coding January 15, 2026 22:49
log.info("[GRADING-FLOW] Publishing StudentCodeSubmittedEvent");
publishStudentCodeSubmittedEvent(codeSubmission);
log.info("[GRADING-FLOW] StudentCodeSubmittedEvent published successfully");
String lastProcessedCommit = metadata.getLastProcessedCommitSha();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method looks a bit long

nk-coding
nk-coding previously approved these changes Jan 15, 2026
@nk-coding

Copy link
Copy Markdown
Contributor

@copilot fix the merge conflicts

Copilot AI commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

@nk-coding I've opened a new pull request, #22, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot and others added 3 commits January 15, 2026 23:19
Resolved merge conflicts in GradingService.java by combining:
- Refactored helper methods from bugfix branch
- Detailed logging statements from main branch
Resolve merge conflicts in GradingService.java by combining refactored methods with logging
@MP-DG MP-DG merged commit b55e507 into main Jan 15, 2026
1 check failed
@MP-DG MP-DG deleted the bugfix-multiple-proactive-feedback branch January 15, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants