Skip to content

Fix the picked items from the client audit - #271

Open
Paul1365972 wants to merge 9 commits into
MCHPR:masterfrom
Paul1365972:fix/client-audit
Open

Paul1365972 wants to merge 9 commits into
MCHPR:masterfrom
Paul1365972:fix/client-audit

Conversation

@Paul1365972

Copy link
Copy Markdown
Contributor

This PR fixes most of the items from the audit we discussed on Discord and @StackDoubleFlow filtered.

Changes:

  • fix(network): reject VarInts longer than five bytes instead of panicking: Previously the sixth byte paniced the thread reading that connection.
  • fix(network): drop connections that close before entering play: Previously they stayed in handshaking_clients with their socket open, one per server list ping.
  • fix(player): close the connection when kicking: Previously kick only sent the disconnect packet, and a timed out player got it again every tick but stayed in the plot.
  • fix(core): give each plot its own broadcast queue: Previously all plots shared one bus of 100 messages and the main thread blocked while one plot did not read it. The new queues are unbounded.
  • fix(core): close connections that acknowledge a login they never completed: Previously the main thread paniced on client.uuid.unwrap() once such a client finished configuration.
  • fix(core): refuse the login when LuckPerms permissions cannot be loaded: Previously a failed query paniced the main thread, now the player is disconnected with a message.
  • fix(permissions): stop matching past the end of a shorter node: Previously checking plots.info against a stored plots node indexed past its end and paniced the plot thread.
  • fix(plot): reject relative plot coordinates that overflow: Previously /plot tp ~2147483647 0 wrapped around to a far away plot, now it is a parse error.
  • fix(core): match the whole name in /tp and teleport to that player: Previously the server matched a prefix in any case but the plot only the exact name, so /tp bo moved you to Bob's plot and straight back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant