Repository navigation
Fix the picked items from the client audit - #271
Open
Paul1365972 wants to merge 9 commits into
Open
Paul1365972 wants to merge 9 commits into
Paul1365972 wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the items from the audit we discussed on Discord and @StackDoubleFlow filtered.
Changes:
fix(network): reject VarInts longer than five bytes instead of panicking: Previously the sixth byte paniced the thread reading that connection.fix(network): drop connections that close before entering play: Previously they stayed inhandshaking_clientswith their socket open, one per server list ping.fix(player): close the connection when kicking: Previouslykickonly sent the disconnect packet, and a timed out player got it again every tick but stayed in the plot.fix(core): give each plot its own broadcast queue: Previously all plots shared onebusof 100 messages and the main thread blocked while one plot did not read it. The new queues are unbounded.fix(core): close connections that acknowledge a login they never completed: Previously the main thread paniced onclient.uuid.unwrap()once such a client finished configuration.fix(core): refuse the login when LuckPerms permissions cannot be loaded: Previously a failed query paniced the main thread, now the player is disconnected with a message.fix(permissions): stop matching past the end of a shorter node: Previously checkingplots.infoagainst a storedplotsnode indexed past its end and paniced the plot thread.fix(plot): reject relative plot coordinates that overflow: Previously/plot tp ~2147483647 0wrapped around to a far away plot, now it is a parse error.fix(core): match the whole name in /tp and teleport to that player: Previously the server matched a prefix in any case but the plot only the exact name, so/tp bomoved you to Bob's plot and straight back.