Repository navigation
Fix various bugs and remove the binary graph export - #269
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the commits from my fork as discussed on Discord with @StackDoubleFlow.
Changes:
fix(save_data): replace plot, player, and whitelist files atomically: Write plot, player and whitelist files to a temporary file and rename it, so a crash while saving can't corrupt them. The whitelist is now saved when it changes, and a brokenwhitelist.jsonstops the server instead of being treated as empty.fix(blocks): stop trapdoors and portal frames conducting power: Iron trapdoors and end portal frames no longer conduct redstone power, like in vanilla.fix(core): place pumpkins, cauldrons, composters, cake and observers from their items: Some items/blocks couldn't be placed previously, now they can.fix(core): reject non-whitelisted players before login: Actually close the connection of players that are not whitelisted, previously the login went on after the disconnect packet.fix(server): refuse logins above max_players: Enforcemax_players, previously it was only shown in the server list.fix(plot): stop queued commands when a player leaves: Drop the remaining queued commands of a player that left the plot, previously they ran for the wrong player or crashed the plot.fix(world): encode heightmaps in the client's column order with the right heights: Fix the heightmaps sent to the client, x and z were swapped and the heights were wrong.fix(worldedit): confine schematics to their directory: Check the whole schematic name, previously a name like../x.schemcould leave theschemsdirectory.fix(core): name the thread that panicked: The panic message now names the thread that panicked instead of always saying "plot".fix(world_exporter): correct the save folder name, chunk lengths, and height ranges: Fix the world exporter's folder name (invalid on Windows), chunk lengths (off by one) and height range (the world is moved down by 64 blocks).fix(blocks): extend bass drum materials: Fix our note block instrument's material list, some stone blocks were missing and played the harp instead of the bass drum.feat(redpiler): remove binary graph export: Remove--export/-eand theredpiler_graphcrate.