fix(ci+e2e): address Codex review findings on #9/#10#11
Merged
Conversation
- screenshots: build @testudo/core before the extension (clean checkouts lack core/dist, which the extension imports at runtime → build failed). [#9 P2] - screenshots: blocked-page capture waits for the resolved interstitial ('THREAT INTERCEPTED') instead of just <body>, so it no longer snapshots the 'Analyzing…' loading frame (verified: 7.6KB→21.8KB, shows the threat page). [#9 P2] - release.yml: stop uploading the production-keyed bundle as a CI artifact — Actions artifacts are downloadable on a public repo, which would expose the baked TESTUDO_API_KEY and bypass the protected Environment. Upload a sha256 checksum for the audit trail instead; the bundle's only destination is the CWS draft upload. [#10 P1] Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the automated Codex review findings on the now-merged #9 (screenshots) and #10 (release workflow).
screenshotsbuilds only the extension; on a clean checkout@testudo/core/distis missing and the extension imports it at runtime → build failsscreenshotsnow builds@testudo/corefirst<body>, so it could snapshot theAnalyzing…loading frame instead of the interstitialTHREAT INTERCEPTED(the resolved hard-block header) before capturing — verified: image 7.6 KB → 21.8 KB, now shows the threat pagerelease.ymluploaded the production-keyed bundle as a CI artifact — Actions artifacts are downloadable on a public repo, exposing the bakedTESTUDO_API_KEYand bypassing the protected Environmentsha256checksum for the audit trail instead; the bundle's only destination is the CWS draft uploadVerification
yarn screenshotsre-run: 6/6 captures pass; blocked interstitial now renders correctly (THREAT INTERCEPTED · [RISK] CRITICAL · override form).release.yml: no tabs, structure intact (workflow file change, validated on push by GitHub).🤖 Generated with Claude Code