Add configurable sharable preview#4463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a backed enum and config migration for new social-card image settings, updates ChangesOpen Graph image settings
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/View/Components/Meta.php (1)
161-177: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winPrefer the already eager-loaded cover relationship over a fresh query.
Albumeager-loadscover.size_variantsandmin_privilege_cover.size_variants(seeapp/Models/Album.php$with).getCoverUrlissues an additionalSizeVariant::query()for$cover_id, adding a DB round-trip per render. You could read from the loaded relationship (e.g.$album->cover?->size_variants->getMedium2x()?->url ?? ...) to mirror the priority logic inresolveSmCardImageUrlwithout an extra query.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8288f0e2-3b33-47e4-b270-d30be7004919
📒 Files selected for processing (26)
app/Enum/OgImageAlbumSourceType.phpapp/View/Components/Meta.phpdatabase/migrations/2026_06_24_200000_add_og_image_settings.phplang/ar/all_settings.phplang/bg/all_settings.phplang/cz/all_settings.phplang/de/all_settings.phplang/el/all_settings.phplang/en/all_settings.phplang/es/all_settings.phplang/fa/all_settings.phplang/fr/all_settings.phplang/hu/all_settings.phplang/it/all_settings.phplang/ja/all_settings.phplang/nl/all_settings.phplang/no/all_settings.phplang/pl/all_settings.phplang/pt/all_settings.phplang/ru/all_settings.phplang/sk/all_settings.phplang/sv/all_settings.phplang/tr/all_settings.phplang/vi/all_settings.phplang/zh_CN/all_settings.phplang/zh_TW/all_settings.php
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: eeae6ed8-d695-42b7-94e7-e868395ccf25
📒 Files selected for processing (1)
tests/Unit/View/Components/MetaTest.php
Summary by CodeRabbit