Do not display errors when feature is disabled

[ildyria]

Summary by CodeRabbit

• Bug Fixes
  • Reduced unnecessary error popups in several maintenance actions when the backend reports a disabled-feature response.
  • Error messages are now shown only for relevant failures, improving clarity during maintenance tasks.
  • Updated maintenance screens to handle some request failures more smoothly while keeping the interface responsive.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfdbbe19-e433-4b03-91df-111288f60da9

📥 Commits

Reviewing files that changed from the base of the PR and between 22640a1 and fe1e632.

📒 Files selected for processing (5)

• resources/js/components/maintenance/MaintenanceBulkScanFaces.vue
• resources/js/components/maintenance/MaintenanceDestroyDismissedFaces.vue
• resources/js/components/maintenance/MaintenanceResetFaceScanStatus.vue
• resources/js/components/maintenance/MaintenanceRunClustering.vue
• resources/js/components/maintenance/MaintenanceSyncFaceEmbeddings.vue

---

📝 Walkthrough

Walkthrough

Five face-related maintenance Vue components (MaintenanceBulkScanFaces, MaintenanceDestroyDismissedFaces, MaintenanceResetFaceScanStatus, MaintenanceRunClustering, MaintenanceSyncFaceEmbeddings) are updated to suppress error toast notifications when the backend responds with HTTP 501 and the message "Feature 'v8' is disabled", in both load() and exec() error paths. Two components also remove the load() catch branch entirely.

Changes

v8 Feature-Disabled Toast Suppression

Layer / File(s)	Summary
load() catch-path changes resources/js/components/maintenance/MaintenanceBulkScanFaces.vue, resources/js/components/maintenance/MaintenanceDestroyDismissedFaces.vue, resources/js/components/maintenance/MaintenanceResetFaceScanStatus.vue, resources/js/components/maintenance/MaintenanceRunClustering.vue, resources/js/components/maintenance/MaintenanceSyncFaceEmbeddings.vue	BulkScanFaces, DestroyDismissedFaces, and ResetFaceScanStatus add a guard in load()'s catch that skips the error toast when the response is 501 / "Feature 'v8' is disabled". RunClustering and SyncFaceEmbeddings remove the load() catch branch entirely, leaving only the .then(...) success path.
exec() catch-path changes resources/js/components/maintenance/MaintenanceBulkScanFaces.vue, resources/js/components/maintenance/MaintenanceDestroyDismissedFaces.vue, resources/js/components/maintenance/MaintenanceResetFaceScanStatus.vue, resources/js/components/maintenance/MaintenanceRunClustering.vue, resources/js/components/maintenance/MaintenanceSyncFaceEmbeddings.vue	All five components replace unconditional error toast display in exec()'s catch with a conditional check: toasts are suppressed when e.response.status === 501 or e.response.data.message === "Feature 'v8' is disabled"; when shown, the toast detail now uses e.response.data.message without optional chaining.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Hoppity-hop through the error queue,
When v8's asleep, no toast for you!
Five components patched with a tidy guard,
Status 501? Discarded, not scarred.
The rabbit checks the message with care,
Silent on failures that shouldn't be there! 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: one or more packages not found in the registry.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}