Conversation
📝 WalkthroughWalkthroughThe facial recognition configuration guide is expanded to add a full non-Docker (bare-metal) setup section covering installation, ChangesFacial Recognition Guide: Bare-Metal & Docker Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/specs/2-how-to/configure-facial-recognition.md (1)
114-219: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winSystemd unit uses 127.0.0.1 binding; consider clarity for production multi-machine deployments.
The manual startup instruction (line 175) binds to
0.0.0.0(all interfaces), but the systemd unit example (line 192) binds to127.0.0.1(localhost only). This inconsistency is not incorrect—given that bare-metal setup assumes a single machine and Lychee's bare-metal config (line 165) points tohttp://localhost:8000—but it could confuse users scaling to separate machines.Consider adding a comment in the systemd unit clarifying that
127.0.0.1is appropriate for localhost-only access, and that0.0.0.0should be used if Lychee runs on a different host.📝 Suggested clarification in the systemd unit
[Service] Type=simple User=www-data WorkingDirectory=/opt/Lychee-Facial-Recognition EnvironmentFile=/opt/Lychee-Facial-Recognition/.env +# Bind to 127.0.0.1 for localhost-only access; use 0.0.0.0 if Lychee runs on a different host ExecStart=/usr/bin/uv run uvicorn app.main:app --host 127.0.0.1 --port 8000 Restart=on-failure RestartSec=5
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31054a38-a508-494a-90e6-746c2f346f86
📒 Files selected for processing (1)
docs/specs/2-how-to/configure-facial-recognition.md
Summary by CodeRabbit