Add Legal warning about facial recogntion#4443
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a dismissible facial recognition legal warning feature. A new ChangesFace Recognition Legal Warning Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
routes/api_v2.php (1)
178-178: 🧹 Nitpick | 🔵 TrivialLogin endpoint is already rate-limited via inherited 'api' middleware; commented throttle references undefined rate limiter.
The login route at line 178 inherits the
apimiddleware applied to all routes inapi_v2.php(configured inRouteServiceProvider.phpline 50), which enforces a rate limit of 60 requests per minute. This provides baseline protection against brute force attacks.However, the commented-out throttle middleware references
throttle:10,60,login, which attempts to define a custom 10 requests per 60 seconds limit for the login endpoint. This is broken because there is no'login'rate limiter defined in the codebase—only'api'and'geo-queue'limiters exist inRouteServiceProvider.php. If uncommented, this would likely fail or silently fall back to the default'api'limiter.If stricter rate limiting for authentication endpoints is desired, define a proper
'login'rate limiter inRouteServiceProvider.phpand uncomment the middleware, or update the throttle to use the'api'limiter with a reduced time window.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d379a34c-5d05-412c-835f-76aa77b50437
📒 Files selected for processing (53)
app/Http/Resources/Rights/ModulesRightsResource.phpdatabase/migrations/2026_06_21_000001_add_face_recognition_warning_config.phplang/ar/all_settings.phplang/ar/people.phplang/bg/all_settings.phplang/bg/people.phplang/cz/all_settings.phplang/cz/people.phplang/de/all_settings.phplang/de/people.phplang/el/all_settings.phplang/el/people.phplang/en/all_settings.phplang/en/people.phplang/es/all_settings.phplang/es/people.phplang/fa/all_settings.phplang/fa/people.phplang/fr/all_settings.phplang/fr/people.phplang/hu/all_settings.phplang/hu/people.phplang/it/all_settings.phplang/it/people.phplang/ja/all_settings.phplang/ja/people.phplang/nl/all_settings.phplang/nl/people.phplang/no/all_settings.phplang/no/people.phplang/pl/all_settings.phplang/pl/people.phplang/pt/all_settings.phplang/pt/people.phplang/ru/all_settings.phplang/ru/people.phplang/sk/all_settings.phplang/sk/people.phplang/sv/all_settings.phplang/sv/people.phplang/tr/all_settings.phplang/tr/people.phplang/vi/all_settings.phplang/vi/people.phplang/zh_CN/all_settings.phplang/zh_CN/people.phplang/zh_TW/all_settings.phplang/zh_TW/people.phpresources/js/components/faceRecog/FaceRecognitionWarning.vueresources/js/lychee.d.tsresources/js/views/face-recog/FaceClusters.vueresources/js/views/face-recog/FaceMaintenance.vueroutes/api_v2.php
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit