Skip to content

Pin -rc releases#4413

Merged
ildyria merged 1 commit into
masterfrom
add-rc-releases
Jun 13, 2026
Merged

Pin -rc releases#4413
ildyria merged 1 commit into
masterfrom
add-rc-releases

Conversation

@ildyria

@ildyria ildyria commented Jun 13, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline to prevent release-candidate versions from being tagged as latest release.

@ildyria ildyria requested a review from a team as a code owner June 13, 2026 09:40
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request tightens GitHub Actions workflow conditions to prevent release-candidate versions from being marked as production releases. Docker builds for standard and legacy images no longer apply the latest tag to -rc versions, and the release job is restricted to non-candidate tags only.

Changes

RC Version Filtering in CI/CD Workflows

Layer / File(s) Summary
Docker latest tag and release job filtering
.github/workflows/CICD.yml
Docker metadata latest tag conditions for standard (line 237) and legacy (line 346) builds now exclude tags ending with -rc. Release job condition (line 451) is similarly restricted to non-RC tag refs, ensuring pre-release versions skip production tagging and release execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 RC versions hop past the latest tag today,
With -rc checks added along the CI way,
No more pre-releases in production's bright light—
Just stable releases approved to take flight! 🚀

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/CICD.yml (1)

237-237: Keep -rc filtering case-sensitive; current repo tags don’t use uppercase RC

endsWith(github.ref, '-rc') is case-sensitive, but the repo’s existing git tags show no -RC/-Rc/mixed-case variants (the git tag | grep -iE '(RC|Rc|rC)$' check returned no matches). If you ever introduce uppercase/mixed-case pre-release tags, consider normalizing case in the expression or expanding the suffix checks.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a3747158-d99f-4d8d-a062-dd7d90fb6ff8

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3d97b and f20778f.

📒 Files selected for processing (1)
  • .github/workflows/CICD.yml

@ildyria ildyria merged commit 9edf3f6 into master Jun 13, 2026
45 checks passed
@ildyria ildyria deleted the add-rc-releases branch June 13, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant