Pin -rc releases#4413
Conversation
📝 WalkthroughWalkthroughThe pull request tightens GitHub Actions workflow conditions to prevent release-candidate versions from being marked as production releases. Docker builds for standard and legacy images no longer apply the ChangesRC Version Filtering in CI/CD Workflows
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/CICD.yml (1)
237-237: Keep-rcfiltering case-sensitive; current repo tags don’t use uppercase RC
endsWith(github.ref, '-rc')is case-sensitive, but the repo’s existing git tags show no-RC/-Rc/mixed-case variants (thegit tag | grep -iE '(RC|Rc|rC)$'check returned no matches). If you ever introduce uppercase/mixed-case pre-release tags, consider normalizing case in the expression or expanding the suffix checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a3747158-d99f-4d8d-a062-dd7d90fb6ff8
📒 Files selected for processing (1)
.github/workflows/CICD.yml
Summary by CodeRabbit