Add better feedback on upload failures#4412
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a configuration setting to auto-close the upload panel when all files complete successfully. The backend registers a boolean config and exposes it via UploadConfig, the frontend Vue component differentiates upload completion states (errors, warnings, success) with distinct messages and conditional modal closure, and localization covers many languages. ChangesAuto-close Upload Panel on Success
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 13
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62908e8c-f4e3-4319-b34e-ed94d826a694
📒 Files selected for processing (50)
app/Http/Resources/GalleryConfigs/UploadConfig.phpdatabase/migrations/2026_06_13_000001_add_close_upload_on_success_config.phplang/ar/all_settings.phplang/ar/dialogs.phplang/bg/all_settings.phplang/bg/dialogs.phplang/cz/all_settings.phplang/cz/dialogs.phplang/de/all_settings.phplang/de/dialogs.phplang/el/all_settings.phplang/el/dialogs.phplang/en/all_settings.phplang/en/dialogs.phplang/es/all_settings.phplang/es/dialogs.phplang/fa/all_settings.phplang/fa/dialogs.phplang/fr/all_settings.phplang/fr/dialogs.phplang/hu/all_settings.phplang/hu/dialogs.phplang/it/all_settings.phplang/it/dialogs.phplang/ja/all_settings.phplang/ja/dialogs.phplang/nl/all_settings.phplang/nl/dialogs.phplang/no/all_settings.phplang/no/dialogs.phplang/pl/all_settings.phplang/pl/dialogs.phplang/pt/all_settings.phplang/pt/dialogs.phplang/ru/all_settings.phplang/ru/dialogs.phplang/sk/all_settings.phplang/sk/dialogs.phplang/sv/all_settings.phplang/sv/dialogs.phplang/tr/all_settings.phplang/tr/dialogs.phplang/vi/all_settings.phplang/vi/dialogs.phplang/zh_CN/all_settings.phplang/zh_CN/dialogs.phplang/zh_TW/all_settings.phplang/zh_TW/dialogs.phpresources/js/components/modals/UploadPanel.vueresources/js/lychee.d.ts
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5aa5a31d-46d3-43b8-8fb3-66c1a85d1820
📒 Files selected for processing (23)
lang/ar/all_settings.phplang/bg/all_settings.phplang/cz/all_settings.phplang/de/all_settings.phplang/el/all_settings.phplang/en/all_settings.phplang/es/all_settings.phplang/fa/all_settings.phplang/fr/all_settings.phplang/hu/all_settings.phplang/it/all_settings.phplang/ja/all_settings.phplang/nl/all_settings.phplang/no/all_settings.phplang/pl/all_settings.phplang/pt/all_settings.phplang/ru/all_settings.phplang/sk/all_settings.phplang/sv/all_settings.phplang/tr/all_settings.phplang/vi/all_settings.phplang/zh_CN/all_settings.phplang/zh_TW/all_settings.php
✅ Files skipped from review due to trivial changes (6)
- lang/el/all_settings.php
- lang/cz/all_settings.php
- lang/nl/all_settings.php
- lang/de/all_settings.php
- lang/vi/all_settings.php
- lang/fa/all_settings.php
🚧 Files skipped from review as they are similar to previous changes (4)
- lang/hu/all_settings.php
- lang/no/all_settings.php
- lang/it/all_settings.php
- lang/sk/all_settings.php
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Localization