Add option to disable the switch photo effect#4410
Conversation
📝 WalkthroughWalkthroughThis PR adds a gallery configuration flag ChangesDisable Swipe Effect Photo Viewer Configuration
CI and Docker updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fdabebcf-847e-4716-b81b-8f61b11176d5
📒 Files selected for processing (28)
app/Http/Resources/GalleryConfigs/InitConfig.phpdatabase/migrations/2026_06_10_000001_disable_swipe_effect_photo_viewer.phplang/ar/all_settings.phplang/bg/all_settings.phplang/cz/all_settings.phplang/de/all_settings.phplang/el/all_settings.phplang/en/all_settings.phplang/es/all_settings.phplang/fa/all_settings.phplang/fr/all_settings.phplang/hu/all_settings.phplang/it/all_settings.phplang/ja/all_settings.phplang/nl/all_settings.phplang/no/all_settings.phplang/pl/all_settings.phplang/pt/all_settings.phplang/ru/all_settings.phplang/sk/all_settings.phplang/sv/all_settings.phplang/tr/all_settings.phplang/vi/all_settings.phplang/zh_CN/all_settings.phplang/zh_TW/all_settings.phpresources/js/components/gallery/photoModule/PhotoPanel.vueresources/js/lychee.d.tsresources/js/stores/LycheeState.ts
There was a problem hiding this comment.
🧹 Nitpick comments (2)
Dockerfile (1)
72-72: 💤 Low valueUpdate OCI base.name label to reflect the pinned FrankenPHP version.
The label still references the generic tag
dunglas/frankenphp:php8.5-trixie, but line 59 now pins to version1.12.4. For accuracy and traceability, update the label to match the pinned version.📝 Suggested label update
-LABEL org.opencontainers.image.base.name="dunglas/frankenphp:php8.5-trixie" +LABEL org.opencontainers.image.base.name="dunglas/frankenphp:1.12.4-php8.5-trixie"Dockerfile-legacy (1)
58-58: Consider stability implications of Debian trixie (testing).The base image has been upgraded from
debian:bookworm-slim(Debian 12 stable) todebian:trixie-slim(Debian 13 testing). Debian testing receives less rigorous stability guarantees than stable releases and may introduce unexpected package updates or breakages in production environments.The TODO comments at lines 56-57 suggest this migration was planned. Ensure that:
- This change has been tested in staging/CI environments
- The production deployment strategy accounts for potential instability
- There is a rollback plan if issues arise
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d745bd9e-f1e2-43b0-b17c-d95719b662ec
📒 Files selected for processing (4)
.github/workflows/js_check.ymlDockerfileDockerfile-demoDockerfile-legacy
💤 Files with no reviewable changes (1)
- .github/workflows/js_check.yml
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile-legacy (1)
56-57: ⚡ Quick winStale TODO comments should be removed or updated.
The TODO comments appear outdated given the current state of the Dockerfile:
- Line 56 says "migrate to trixie once php8.5-zip is fixed" but the base image is already
debian:trixie-slimand uses php8.5 packages.- Line 57 says "Fix Imagick sed once we update the version of Imagick" but the sed command on line 120 has been updated to target
/etc/ImageMagick-7/policy.xml.Consider removing these TODOs or clarifying what remains to be addressed.
Suggested fix
-# TODO: migrate to trixie once php8.5-zip is fixed. -# TODO: Fix Imagick sed once we update the version of Imagick. FROM debian:trixie-slim@sha256:4e401d95de7083948053197a9c3913343cd06b706bf15eb6a0c3ccd26f436a0e AS base
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4e0dca97-9a98-482a-b73c-abd250713606
📒 Files selected for processing (2)
Dockerfile-legacyMakefile
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
Localization
Chores