Skip to content

Display Camera Make in PhotoDetails Exif Data#4389

Merged
ildyria merged 3 commits into
LycheeOrg:masterfrom
rschumm:display-camera-make
Jun 1, 2026
Merged

Display Camera Make in PhotoDetails Exif Data#4389
ildyria merged 3 commits into
LycheeOrg:masterfrom
rschumm:display-camera-make

Conversation

@rschumm

@rschumm rschumm commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Lychee is only Displaying «Model» in PhotoDetails Exif Data.
Non-Canon Cameras do not include the Brand Name in the Camera Model - e.g. Sony and Leica will just display the model name. Though, the data is already present in Lychee Backend and Database.
This Feature Displays the Camera Model in a very minimal way.

Note: For Canon Cameara (and maybe others?) the Brand «Canon» will be duplicated, but I think this is ok.

Current Behaviour with a Sony Camera:

Bildschirmfoto 2026-06-01 um 09 13 51

Summary by CodeRabbit

  • Bug Fixes
    • Improved camera info in photo details: EXIF now shows a cleaner camera string—empty when missing, just the model when make is absent or already included, or "Make - Model" otherwise. The EXIF row still only appears when camera data is present.

@rschumm rschumm requested a review from a team as a code owner June 1, 2026 07:17
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d219986b-5fd4-42cd-84d1-066d9695e38c

📥 Commits

Reviewing files that changed from the base of the PR and between 7e2e0fd and b25bdcb.

📒 Files selected for processing (1)
  • resources/js/components/drawers/PhotoDetails.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/js/components/drawers/PhotoDetails.vue

📝 Walkthrough

Walkthrough

PhotoDetails.vue replaces direct rendering of the preformatted model with a new computed cameraModel that conditionally renders an empty string, the model, or make - model depending on presence and whether the model already includes the make.

Changes

EXIF Camera Display

Layer / File(s) Summary
cameraModel computed and EXIF UI swap
resources/js/components/drawers/PhotoDetails.vue
Imports computed, adds cameraModel (formats make and model with null/empty and prefix rules) and updates the EXIF camera row to display cameraModel instead of the raw preformatted model.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibbled code with care tonight,
Made make and model sit just right,
A dash between, no duplicate name,
The EXIF reads tidy — that's my game!

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rschumm

rschumm commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Note: I was not sure if Test is neede for this small feature.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4bf3f65b-2579-4c47-8887-7df832d88702

📥 Commits

Reviewing files that changed from the base of the PR and between 46c372d and bee34da.

📒 Files selected for processing (1)
  • resources/js/components/drawers/PhotoDetails.vue

Comment thread resources/js/components/drawers/PhotoDetails.vue Outdated
as proposed by CodeRabbit
@ildyria

ildyria commented Jun 1, 2026

Copy link
Copy Markdown
Member

Hi, thank you for your PR, I will need to check locally if it gives me "Canon - Canon R5" 👍

@ildyria

ildyria commented Jun 1, 2026

Copy link
Copy Markdown
Member
image

@ildyria ildyria enabled auto-merge (squash) June 1, 2026 12:30
@ildyria ildyria merged commit fa089ef into LycheeOrg:master Jun 1, 2026
44 checks passed
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (46c372d) to head (b25bdcb).
⚠️ Report is 3 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rschumm

rschumm commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

This is wonderful! Thanks a lot for the quick integration and enhancement of my first contribution to Lychee! I love the tool - and your very modern and clean way of working.
more to come from me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants