Display Camera Make in PhotoDetails Exif Data#4389
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughPhotoDetails.vue replaces direct rendering of the preformatted model with a new computed ChangesEXIF Camera Display
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note: I was not sure if Test is neede for this small feature. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4bf3f65b-2579-4c47-8887-7df832d88702
📒 Files selected for processing (1)
resources/js/components/drawers/PhotoDetails.vue
as proposed by CodeRabbit
|
Hi, thank you for your PR, I will need to check locally if it gives me "Canon - Canon R5" 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
This is wonderful! Thanks a lot for the quick integration and enhancement of my first contribution to Lychee! I love the tool - and your very modern and clean way of working. |

Lychee is only Displaying «Model» in PhotoDetails Exif Data.
Non-Canon Cameras do not include the Brand Name in the Camera Model - e.g. Sony and Leica will just display the model name. Though, the data is already present in Lychee Backend and Database.
This Feature Displays the Camera Model in a very minimal way.
Note: For Canon Cameara (and maybe others?) the Brand «Canon» will be duplicated, but I think this is ok.
Current Behaviour with a Sony Camera:
Summary by CodeRabbit