Repository navigation
Conversation
Graffioh
changed the title
Graffioh
changed the title
Graffioh
changed the title
Graffioh
force-pushed
the
codex/unit-test-refactor
branch
3 times, most recently
from
September 5, 2026 12:42
b908255 to
4a0746e
Compare
Graffioh
marked this pull request as ready for review
September 5, 2026 12:49
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 81 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Graffioh
force-pushed
the
codex/unit-test-refactor
branch
from
September 6, 2026 05:53
4a0746e to
95e256e
Compare
Graffioh
force-pushed
the
codex/unit-test-refactor
branch
2 times, most recently
from
September 14, 2026 16:36
66e5ace to
04102c6
Compare
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@Graffioh I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 75 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Graffioh
force-pushed
the
codex/unit-test-refactor
branch
from
September 15, 2026 09:05
04102c6 to
565bc01
Compare
Split the 7k-line server/test/test_server_unit.cpp monolith into
component-oriented files under server/test/{common,deepseek4,draft,kernels,
kvflash,moe,placement,qwen3,qwen35,server} matching the production layout,
with shared fixtures/mocks under server/test/support/.
Removes low-value coverage (formula-copying, assignment-only, simulated
allocation, and suite-in-suite tests) and converts the feature-gate suite to
per-case TEST_CASEs. Relocates all remaining upstream coverage verbatim,
including the tests added on main since the original branch point.
Graffioh
force-pushed
the
codex/unit-test-refactor
branch
from
September 15, 2026 09:24
565bc01 to
72e9851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server unit suite mixed unrelated components in a 7,222-line source file, while several regression tests checked copied formulas, simulated allocations, or JSON constructed inside the test. Organize the model-free suite by component, preserving existing coverage verbatim in the new layout.
server/test/server/,common/,moe/,qwen3/,qwen35/,deepseek4/,kvflash/,placement/,draft/, andkernels/; shared fixtures live insupport/. Move the DS4/Qwen/MoE standalone sources into the same component layout, preserve their targets, and document the layout inserver/test/README.md.test_server_unittarget and historical selectors for retained cases. Separate session-container tests from the adaptive controller. Expose all 23 standalone feature-gate rule groups as individual CTest cases.mainsince the original branch point.No production APIs or runtime state change. GPU/model test sources retain their existing targets and hardware requirements. The README identifies HTTP policy/telemetry integration coverage that the removed simulations never established.
New and strengthened coverage is mostly split into a stacked follow-up so this PR stays close to a pure reorganization; the exceptions shipping here are the session LRU eviction-bounds and EMA read-back cases (
lru_eviction_bounds_map_size,get_ema_reflects_post_update_value).Test plan
test_server_unitdiscovers 543 cases;ctestpasses 541/543 — the only 2 failures are upstream-verbatimMixedMmqPolicycases segfaulting insidelibamdhip64/ggml HIP kernels on this gfx1201+gfx1151 box (pre-existing environment issue, unchanged by this PR).git diff --checkclean.Generated with Devin