Skip to content

fix: gate json fetch timestamp option#449

Merged
davide221 merged 1 commit into
mainfrom
fix/json-fetchcontent-cmake-compat
Jun 24, 2026
Merged

fix: gate json fetch timestamp option#449
davide221 merged 1 commit into
mainfrom
fix/json-fetchcontent-cmake-compat

Conversation

@davide221

@davide221 davide221 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What

Fix the Docker prebuild configure failure by only passing
DOWNLOAD_EXTRACT_TIMESTAMP to FetchContent_Declare() when the active CMake
version supports it.

The Docker images install Ubuntu 22.04's CMake 3.22.1, while
DOWNLOAD_EXTRACT_TIMESTAMP was added in CMake 3.24. CMake 3.22 interprets the
unknown keyword incorrectly and fails while configuring the json FetchContent
subbuild.

Validation

  • git diff --check
  • Ubuntu 22.04 / CMake 3.22.1 focused FetchContent configure: passed
  • macOS / CMake 4.3.1 focused FetchContent configure: passed

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@davide221 davide221 merged commit 976357e into main Jun 24, 2026
5 checks passed
@davide221 davide221 deleted the fix/json-fetchcontent-cmake-compat branch June 26, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant