Added Applications Events for application-level metrics and custom label support in KafkaSink#79
Conversation
…evel metrics and custom metadata support
…evel metrics and custom metadata support
|
Hi, This PR adds substantial new semantics and payload fields (application lifecycle events, counters, labels, config payload), so it can break existing consumers that rely on the current Kafka message contract. Could you please move this into a new listener class such as KafkaSinkV2 ? Also, before merge, I’d ask to fix configurations -> conf.getAll.toMap in applications_ended can leak secrets; please remove it or apply a strict allowlist/redaction strategy. If you go with KafkaSinkV2, please also add documentation with:
Thank you, |
Thanks for the detailed review and for the suggestions — really appreciate you taking the time to go through the changes. I’ll push an updated version of the PR once these changes are in place. |
…SinkV2, testcase and doc
@LucaCanali Please review PR, i have modified PR to have backward compatibility. |
|
Thank you @pp-achauhan ! |
While the existing KafkaSink provides detailed stage, executor, and query metrics, there is currently no built-in support for:
This PR addresses these gaps while preserving backward compatibility with the existing KafkaSink. This PR adds:
spark.sparkmeasure.appLabels.*Happy to adjust naming, packaging, or documentation if needed.