chore: use lizardbyte-common in c++#158
Draft
ReenigneArcher wants to merge 2 commits into
Draft
Conversation
Switch the test suite to shared helpers from `lizardbyte-common` by enabling and linking `lizardbyte::test_support` in `tests/CMakeLists.txt`. Update `conftest.cpp` to inherit from `lizardbyte::common::testing::BaseTest`, use its argument/platform fixtures, and rely on its output capture flow, then remove the now-redundant local `tests/utils.*` helpers. Also bump the `third-party/lizardbyte-common` submodule to the version that provides this test support.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 64.14% 63.83% -0.31%
==========================================
Files 5 5
Lines 647 647
Branches 214 214
==========================================
- Hits 415 413 -2
+ Misses 154 153 -1
- Partials 78 81 +3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #158 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
Matrix: Windows
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
Matrix: macOS
| Image | Baseline | PR |
|---|---|---|
tray_icon_initial.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_displayed.png |
 |
 |
Refactors `tests/conftest.cpp` to rely on shared behavior from `lizardbyte-common` by removing the custom stdout/stderr capture, `exec()` helper, and related teardown plumbing from `BaseTest`. It also updates the fixture comment to reflect tray-specific helpers and advances the `third-party/lizardbyte-common` submodule to the newer commit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use lizardbyte-common helpers.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage