chore: Reduce amount of live stylesheets loaded in tests#7656
Open
mbergen wants to merge 34 commits into
Open
Conversation
mbergen
changed the title
Collaborator
Author
|
Topics for discussion/review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes, loading stylesheets seems to (partially) fail in CI.
This removes loading of skin-specific styles from the live server, loading only fontawesome styles.
Styles used in snapshot tests are (roughly) added to Main.scss, which is only used in tests.
Further, this introduces the
#snapshottag to only execute snapshot tests when usingnpm run update-snapshots.How did you test this change?
N/A