feat(roles/apache_httpd): add csv log formats (and tsv equivalents) - #391
Open
ebuerki-lf wants to merge 12 commits into
Open
ebuerki-lf wants to merge 12 commits into
ebuerki-lf wants to merge 12 commits into
Conversation
… csvsiem" and their tsv equivalents "tsvio tsvextensive tsvsiem"
NavidSassan
requested changes
Sep 18, 2026
NavidSassan
left a comment
NavidSassan
left a comment
Member
There was a problem hiding this comment.
I didnt have a closer look at the formats themselves yet, most comments are about the style
| @@ -1,5 +1,5 @@ | |||
| # {{ ansible_managed }} | |||
Member
There was a problem hiding this comment.
commit message should start with feat(roles/apache_httpd)
Member
There was a problem hiding this comment.
we'll squash it during merge
…nt for csv/tsv log formats. log cloudflare headers CF-Ray CF-Connecting-IP in all csv/tsv formats
ebuerki-lf
changed the title
…g format comments
NavidSassan
reviewed
Sep 22, 2026
| LogFormat "%h %{X-Forwarded-For}i %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\" %I %O" linuxfabrikio | ||
|
|
||
| {# Row 1 of the field tables below looks misaligned here, but lines up in the rendered file. #} | ||
| # csvio, tsvio: based on the linuxfabrikio LogFormat, plus the Cloudflare headers |
Member
There was a problem hiding this comment.
csvio and tsvio put referer and user agent after all three byte counts (%b, %I, %O). That matches neither the other csv/tsv formats nor linuxfabrikio:
- csvextensive/tsvextensive and csvsiem/tsvsiem put them directly after the request line, in the Request group.
linuxfabrikioputs them between%band%I:... "%r" %>s %b "%{Referer}i" "%{User-Agent}i" %I %O
what was the intention / goal of this? which one should we match? or is the deviation intentional? if it is, we need to document why
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.