Repository navigation
feat(config): add semantic loading model - #157
Merged
Merged
Conversation
Add a C++11 parser-neutral configuration document with typed scalar fields, stable diagnostics, structural validation, and a two-phase side-effect-free materialization contract. Keep JSON parsing and live logger construction outside this layer.
Add recursive parser-neutral array and object values so nested backend configuration remains representable. Treat diagnostics emitted by materializer callbacks as failures and preserve the caller's plan until every logger materializes successfully. Extend the contract tests for nested values, fail-closed diagnostics, and atomic plan updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- add a C++11 parser-neutral ConfigurationDocument and typed scalar values\n- add stable diagnostics and structural validation for schema, ids, backend types, strategy fields, and executor queue combinations\n- add a two-phase ConfigurationMaterializer contract that validates before producing a side-effect-free plan\n- keep JSON/properties parsing and live logger instantiation out of this layer\n- add focused test coverage and document the ADR implementation reference\n\n## Verification\n\n- git diff --check\n- configuration_contract_test (C++11 Release)\n\n## Scope\n\nNo live logger construction, parser dependency, or production backend behavior changes.