Skip to content

v3: show prayer times when content runs out; drop the generated schema and Node packer - #4

Merged
IbraTech04 merged 5 commits into
developfrom
claude/wizardly-curie-s90b5i
Nov 19, 2026
Merged

IbraTech04 merged 5 commits into
developfrom
claude/wizardly-curie-s90b5i

Conversation

@IbraTech04

Copy link
Copy Markdown
Collaborator

Board app half of the MusallahBoard offline-first restructure.

Content run-out

When the agent reports expired: true on /api/musallah/payload, the board shows prayer times, the clock, the Hijri date and the weather, all computed or held locally. It also shows a calm note: "Announcements are out of date. Plug in an update stick." Posters, agenda, quotes, socials, the Jummah card and ticker messages are hidden. A next_prayer frame is synthesized if needed, so the screen is never blank. A payload without the field (an older agent) behaves exactly as before.

Removed

  • src/api/schema.d.ts (5,617 lines, stale, only one type used), replaced by a roughly 100-line hand-written types.d.ts checked against the agent's local API.
  • The Node .mbu packer and its tests. Releases now use the agent's mbpack (scripts/package.sh, pinned in release.yml). Output was compared with the old packer: both verify with mbpack verify and the manifests are identical.
  • PLAN.md (superseded), an unused preview harness, and a committed .claude/settings.local.json.
  • README updated: run setup.sh as a normal sudo user; set the board up by plugging in the USB stick exported from the console.

Testing

  • npm ci && npm run build && npm test pass: 77 tests, including 10 new run-out tests. The previous 95 included 28 tests for the deleted packer.
  • Not run: the GitHub release workflow itself. package.sh was run locally.

Generated by Claude Code

The agent marks its payload `expired` once the installed content is past
its last day. The board then keeps the countdown, prayer rail, clock and
weather, drops posters, agenda, quotes, socials, Jummah and ticker
messages (the payload has no evergreen marker, so none of it is kept),
and shows "Announcements are out of date. Plug in an update stick."
A payload without the field, from an older agent, is not expired.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…type

The board read one type from src/api/schema.d.ts, and the file was stale
(the old /api/musallah/* paths). src/api/types.d.ts now describes what the
board reads from the agent: the payload (including the agent's expired and
lastDay) and /api/local/status. Drops the generator script, the api:check
and api:generate scripts, the openapi-typescript dependency and the CI step
that checked out the backend.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
src/qr-preview.jsx says "delete after visual verification" and nothing
loads it. .claude/settings.local.json is one developer's local permission
list (with Windows paths); it is now ignored instead of tracked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…packer

scripts/package-mbu.mjs (390 lines plus 207 of tests) re-implemented the
.mbu writer and signer that the agent's mbpack already is, and the agent
verifies what mbpack writes. The release workflow now installs mbpack at a
pinned agent commit and scripts/package.sh signs dist/ with it and writes
app-channel.json. The package has the same manifest and signature format
(checked: both verify with mbpack verify; the manifests differ only by a
trailing newline); the signing secret and its variable name are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…ne-first

PLAN.md was marked superseded. The README told installers to run
`curl | sudo bash`, but setup.sh refuses to run as root; it now says to run
it as a normal sudo user, that it asks for the content signing key, and that
a board is set up by plugging in the USB stick exported from the console.
Also describes content run-out, the hand-written API types and the mbpack
release build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T16:37:24.174114Z 446f76f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
musallahboard 446f76f Nov 19 2026, 04:36 PM

@IbraTech04
IbraTech04 merged commit 0175d0a into develop Nov 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants