Repository navigation
v3: show prayer times when content runs out; drop the generated schema and Node packer - #4
Merged
Merged
Conversation
The agent marks its payload `expired` once the installed content is past its last day. The board then keeps the countdown, prayer rail, clock and weather, drops posters, agenda, quotes, socials, Jummah and ticker messages (the payload has no evergreen marker, so none of it is kept), and shows "Announcements are out of date. Plug in an update stick." A payload without the field, from an older agent, is not expired. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…type The board read one type from src/api/schema.d.ts, and the file was stale (the old /api/musallah/* paths). src/api/types.d.ts now describes what the board reads from the agent: the payload (including the agent's expired and lastDay) and /api/local/status. Drops the generator script, the api:check and api:generate scripts, the openapi-typescript dependency and the CI step that checked out the backend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
src/qr-preview.jsx says "delete after visual verification" and nothing loads it. .claude/settings.local.json is one developer's local permission list (with Windows paths); it is now ignored instead of tracked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…packer scripts/package-mbu.mjs (390 lines plus 207 of tests) re-implemented the .mbu writer and signer that the agent's mbpack already is, and the agent verifies what mbpack writes. The release workflow now installs mbpack at a pinned agent commit and scripts/package.sh signs dist/ with it and writes app-channel.json. The package has the same manifest and signature format (checked: both verify with mbpack verify; the manifests differ only by a trailing newline); the signing secret and its variable name are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
…ne-first PLAN.md was marked superseded. The README told installers to run `curl | sudo bash`, but setup.sh refuses to run as root; it now says to run it as a normal sudo user, that it asks for the content signing key, and that a board is set up by plugging in the USB stick exported from the console. Also describes content run-out, the hand-written API types and the mbpack release build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YY5BHXmNUhs48eubkKCNuE
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
musallahboard | 446f76f | Nov 19 2026, 04:36 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board app half of the MusallahBoard offline-first restructure.
Content run-out
When the agent reports
expired: trueon/api/musallah/payload, the board shows prayer times, the clock, the Hijri date and the weather, all computed or held locally. It also shows a calm note: "Announcements are out of date. Plug in an update stick." Posters, agenda, quotes, socials, the Jummah card and ticker messages are hidden. Anext_prayerframe is synthesized if needed, so the screen is never blank. A payload without the field (an older agent) behaves exactly as before.Removed
src/api/schema.d.ts(5,617 lines, stale, only one type used), replaced by a roughly 100-line hand-writtentypes.d.tschecked against the agent's local API..mbupacker and its tests. Releases now use the agent'smbpack(scripts/package.sh, pinned inrelease.yml). Output was compared with the old packer: both verify withmbpack verifyand the manifests are identical.PLAN.md(superseded), an unused preview harness, and a committed.claude/settings.local.json.Testing
npm ci && npm run build && npm testpass: 77 tests, including 10 new run-out tests. The previous 95 included 28 tests for the deleted packer.package.shwas run locally.Generated by Claude Code