Skip to content

Add handling for "message of the day"#87

Open
ewanas wants to merge 2 commits into
masterfrom
motd-c
Open

Add handling for "message of the day"#87
ewanas wants to merge 2 commits into
masterfrom
motd-c

Conversation

@ewanas

@ewanas ewanas commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator

Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@ewanas ewanas requested a review from meejah September 22, 2022 11:39
@donpui donpui mentioned this pull request Sep 22, 2022
6 tasks
@ewanas ewanas marked this pull request as ready for review September 22, 2022 12:28

@meejah meejah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this Go codebase in very much detail, so maybe not the best reviewer ... but there's not tests, does this repo not have unit tests, or ...?

@ewanas

ewanas commented Sep 22, 2022

Copy link
Copy Markdown
Collaborator Author

I haven't looked at this Go codebase in very much detail, so maybe not the best reviewer ... but there's not tests, does this repo not have unit tests, or ...?

C bindings don't have tests yet, but I will add tests for the Go changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants