fix: standardize password validation and refactor admin password reset flow#43
Open
praveen-bhosle wants to merge 3 commits into
Open
fix: standardize password validation and refactor admin password reset flow#43praveen-bhosle wants to merge 3 commits into
praveen-bhosle wants to merge 3 commits into
Conversation
amoghar29
reviewed
Jun 25, 2026
| # marked EE, the LeastAction Enterprise Edition License (see LICENSE_EE.md). | ||
| # Use of this file outside those terms is not permitted. | ||
| import hashlib | ||
| from locale import dcgettext |
amoghar29
reviewed
Jun 25, 2026
| from .repo import UserRepository | ||
| from .schema import CreateUser, User | ||
| from .schema import CreateUser, UpdateUser, User | ||
|
|
Collaborator
There was a problem hiding this comment.
use full path imports and not relative imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes the minimum password length across the application to ensure consistency between the frontend and backend validation layers. It also refactors the administrator password reset flow to automatically generate secure passwords and enforce a first-time login password change for affected users. Lastly, it cleans up the codebase by removing redundant marketplace authentication pages.
What’s Included
min_length=6.marketplace-loginandmarketplace-signuppages to streamline the authentication routing.Why This Change
Acceptance Criteria
How to Test
Tech Guide
Field(..., min_length=6)to the relevant Pydantic user/auth schemas.requires_password_changeor equivalent boolean) on the user model that is flipped toTrueduring an admin reset and checked during the login handshake middleware/route.User Guide (Only if user-facing)
Screenshots / Videos (Mandatory for UI changes)
reset_password.mp4
Checklist