Skip to content

fix: stop log streams from blocking worker event loops (#11) #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeastAction-Labs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop log streams from blocking worker event loops (#11) #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e220d1a
fix: stop log streams from blocking worker event loops (#11)
LeastAction-Labs Jun 17, 2026
1c62d3a
fix: bound heavy log ops with a wall-clock timeout (#11)
LeastAction-Labs Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions backend/src/core/api/routes/logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# LeastAction Sustainable Use License (see LICENSE.md) or, for files
# marked EE, the LeastAction Enterprise Edition License (see LICENSE_EE.md).
# Use of this file outside those terms is not permitted.
import asyncio
import json
import traceback
from collections.abc import AsyncGenerator
Expand All @@ -17,7 +16,12 @@
from src.common.config import Config
from src.common.context_vars.user_context import get_user_laui
from src.common.logger.logger import log_error, log_info
from src.core.logs_details.service import LogsService, get_logs_service
from src.core.logs_details.service import (
LOG_QUERY_TIMEOUT,
LogsService,
get_logs_service,
run_log_op,
)

logs_router = APIRouter()

Expand Down Expand Up @@ -94,10 +98,16 @@ async def query_logs(request: LogQueryRequest) -> dict:
log_info(
"api", "logs_router", "query_logs", f"user={get_user_laui()} payload={request.model_dump()}"
)
loop = asyncio.get_event_loop()
return await loop.run_in_executor(
None, _run_duckdb_query, request.sql, request.category, request.date
)
try:
return await run_log_op(
_run_duckdb_query,
request.sql,
request.category,
request.date,
timeout=LOG_QUERY_TIMEOUT,
)
except TimeoutError as exc:
return {"error": str(exc)}


def _sse(event: str, data: Any) -> str:
Expand Down
Loading
Loading