Repository navigation
fix(storage): bounds-check disk array updates in release builds - #1115
Merged
Merged
Conversation
DiskArrayInternal::get already rejects an out-of-range index in release builds. update() still wrapped that check in DASSERT, which release builds compile out, so the throw never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #1095.
DiskArrayInternal::getcallscheckOutOfBoundAccessdirectly, so a corrupt slot id throws in a release build.updatestill wrapped that call inDASSERT. In a release buildDASSERTisvoid(0), so the throw was compiled out and an index pastnumElementswas written.updatenow callscheckOutOfBoundAccessthe same waygetdoes. The otherDASSERTs indisk_array.cppare unchanged.Test.
DiskArrayCollectionTest.RejectsElementIndexOutsideDiskArrayalso callsupdateatnumElementsand at a far index. Built Release withENABLE_RUNTIME_CHECKSoff:updatecalls threw nothing (the existinggetassertions already threw).disk_array_collection_testpasses 5/5, including those twoupdatecalls.Types of changes
Checklist