Repository navigation
build: package the single-file header script for source builds - #43
Merged
adsharma merged 1 commit intoSep 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lbug0.21.0 on crates.io cannot be built from source (LBUG_BUILD_FROM_SOURCE=1/LBUG_RUST_BUILD_FROM_SOURCE=1).build.rsnow setsBUILD_SINGLE_FILE_HEADER=ON(#ca706e5; 0.20.4 had itOFF). With that on,lbug-src/src/CMakeLists.txtrunsscripts/collect-single-file-header.py, and that script readsscripts/headers.txt. Neither file is in the packageincludelist, so the build fails:Fix
lbug-src/scripts/collect-single-file-header.pyandlbug-src/scripts/headers.txttopackage.include.rerun-if-changedlines, as the comment inbuild.rsasks.Verification
lbug-srcsymlinked to av0.21.0checkout of LadybugDB/ladybug:cargo package --listnow includes both files.LBUG_BUILD_FROM_SOURCE=1 cargo packagesucceeds. Cargo's package verification builds the extracted tarball from source, andout/build/src/lbug.hppis generated.A 0.21.1 with this change would let downstream crates that build from source move to 0.21.