Conversation
… numeric Merging sorted key blocks ignored trailing keys once all STRING keys tied, misordering the second key (deterministic with multiple key blocks, e.g. 20k rows).
adsharma
force-pushed
the
fix-1067-orderby-regression
branch
from
September 29, 2026 17:01
2573fdc to
3fe5b42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for LadybugDB/ladybug#1067.
Covers the KeyBlockMerger bug where merging sorted key blocks ignored trailing keys once all STRING keys tied, misordering e.g.
ORDER BY <STRING>, <numeric>. Deterministic once the sort spills to multiple key blocks (20k rows).Companion fix: LadybugDB/ladybug#1072. Test fails before the fix (
rows == sorted(rows)is False) and passes after. CI will validate.