CODE REVIEW squad 4 Mariel #33
Open
marielcarrillo wants to merge 16 commits into
Open
Conversation
AdrianaHY
reviewed
Feb 13, 2020
| <div> | ||
| <button class="start-button" onclick="secondPage()"> COMENZAR </button> | ||
| <button class="start-button" onclick="secondPage()" title="changeBackground"> COMENZAR </button><!--secondPage() estoy llamando a la funcion desde js--> | ||
| </div> |
There was a problem hiding this comment.
La indentacion y los comentarios es algo que hay que cuidar.
AdrianaHY
reviewed
Feb 13, 2020
| </section> | ||
| <section class="secondpage" id="secondPage"> <!--segunda pantalla--> | ||
| <section class="secondpage" id="secondPage"> <!--segunda pantalla --> | ||
| <div class="content-message"> |
There was a problem hiding this comment.
Utiliza una conveción u otra, secondPage, second-page, pero usala en todo tu código
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visualmente quedó bien, pero tengo unas dudas en cuanto el código de CSS y JS.
CSS:
el ancho de los botones a pesar de que los ponía del mismo tamaño aparecían de diferentes tamaños, lo mismo me paso con las cajas de texto donde una es un "text-area" y la otra un "p".
también a pesar de que los objetos quedaron en el lugar esperado, en el código lo hice con position: absolute y tuve que ir calando mediante "prueba y error" para atinarle a la posición deseada.
JS:
baje eslint y me marca que la función secondPage() esta definida pero no nunca usada, pero si me jala, no se a que se deba que salga ese error :/