fix cli empty-long arg panic and optional --db in memory mode#81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passwd_data,acl_dataand 15 other optional inline-content args used#[arg(long = "")], which clap registers as the empty long option--, tripping adebug_asserton the duplicate. Release builds skip the assert and silently mis-defined the flags. Each now has a distinct hidden long name (--passwd-data,--acl-data, …).agent start --memory-backendno longer requires--db(nowrequired_unless_present = "memory_backend"; defaults to a temp dir the in-memory backend never touches).Cli::command().debug_assert()regression test so a future empty/duplicate long name fails CI instead of only crashing debug binaries.Test plan
cargo test -p mqdb-cli cli_testspasses (cli_definition_is_valid,memory_backend_makes_db_optional)mqdb agent start --helpruns without paniccargo make devgreen