Add regression coverage for an unconfirmed merge response

[LSantha]

Summary

The merge helper now tolerates GitHub empty responses and re-fetches the PR to confirm merged: true. Add regression coverage for the opposite case: the merge call returns without error, but the follow-up PR read reports merged: false.

Affected behavior

Both the ticket-runner and batch-orchestrator auto-merge paths should keep the task in REVIEW and surface a merge failure rather than claiming success when the PR is not actually merged.

Scope

• Add focused tests for the unconfirmed-merge response in the ticket-runner and orchestrator test suites.
• Reuse the existing mergePR verification behavior; do not change production semantics unless a test exposes a missing error path.
• Assert the issue/master state is not advanced to DONE and a failure comment is recorded.

Acceptance criteria

• Empty successful response with merged: false is not treated as success.
• No Java, ASM, build, or CI workflow files are changed.
• The Node test suite remains green.

Test path

Run node --test .github/scripts/tests/*.test.js.

Merge signal

Auto-merge is appropriate: kind/chore, regression-test hardening, no Java or build surface.

Triage Addendum (auto, 2026-09-26)

• Area / Kind: area/test + kind/chore
• Blast radius: L0 method (test files only - .github/scripts/tests/*.test.js; no production module change intended)
• Expected scope: .github/scripts/tests/ticket-runner.test.js and .github/scripts/tests/orchestrator.test.js; stub pulls.merge to resolve empty and pulls.get to return merged: false; assert phase never reaches DONE, plus merge_failed history entry and failure comment. No-go: core/src/**, *.asm, all/build.xml, .github/workflows/**, mergePR semantics.
• Test path: node --test .github/scripts/tests/*.test.js
• Merge signal: safe (test-only, ~2 files / <150 added lines, no boot path, no public API change, working verify command)
• Gaps: non-blocking - the mergePR throw path leaves state.phase = "MERGE", not REVIEW (.github/scripts/ticket-runner.js:718 and :548 catch blocks); assert "not DONE" rather than a REVIEW phase, or file a follow-up if REVIEW rollback is the real intent.
• Full report: ## Triage comment below.

---

❌ Ticket Runner Status

Field	Value
Phase	FAILED
Turn	0/3
Retries	3/3
PR	#691
Review in progress	no
Started	2026-09-26T13:32:41.097Z

[LSantha]

/oc triage issue #690

Triage run ONLY. Load the jnode-triage-issue skill and obey it. Output is exactly one ## Triage comment plus kind/area label edits. FORBIDDEN in this run: git checkout -b, git push, gh pr create, any branch, any PR. Audit kind/area labels (correct mislabels), assess repro-sufficiency, estimate blast radius, post one ## Triage comment (clear shape when actionable, vague shape with the needs-info literals only when human input is truly required).

[LSantha]

Triage

• Area: area/test (Node harness under .github/scripts/tests/; no Java/FS/VM surface)
• Kind: kind/chore (regression tests only, no production behavior change; matches maintainer signal in body — kind/test was the alternative, not stacked)
• Repro: "Add focused tests for the unconfirmed-merge response in the ticket-runner and orchestrator test suites" + acceptance "Empty successful response with merged: false is not treated as success" — target branch: mergePR re-fetch at .github/scripts/orchestrator-helpers.js:174-181 throws merge not confirmed; PR state=...
• Blast radius: L0 method (test files only; mergePR verification path already exists at orchestrator-helpers.js:177, callers already handle the throw in ticket-runner.js:548 and ticket-runner.js:718)
• Expected scope: .github/scripts/tests/ticket-runner.test.js and .github/scripts/tests/orchestrator.test.js; stub pulls.merge to resolve with an empty body and pulls.get to return merged: false; assert phase/state never advances to DONE, a merge_failed history event is recorded, and a failure comment is created. No-go: core/src/**, *.asm, all/build.xml, all/conf/*-plugin-list.xml, .github/workflows/**, and any semantic change to mergePR unless a test exposes a missing error path.
• Test path: node --test .github/scripts/tests/*.test.js (host Node runner, no boot, no ISO)
• Merge signal: safe (kind/chore, ~2 test files and well under 150 added lines, no boot path, no public API or plugin-export change, deterministic host test command; merge after agent approval + green suite)
• Gaps: non-blocking for DEV — the mergePR throw path leaves state.phase = "MERGE", not REVIEW (catch blocks at ticket-runner.js:548 and ticket-runner.js:718 restore no phase). Assert "not DONE" in the new tests; if rollback-to-REVIEW is the actual requirement, that is a production semantics change and belongs in its own ticket.
• Suggested next: fix
• Split proposal: none - focused, single L0 unit
• Labels applied: kind/chore (added — issue had no labels), area/test (added — scripts test harness); no removals

opencode session  |  github run

[LSantha]

/oc Please proceed with this task.

[LSantha]

Created PR #691

opencode session  |  github run

[LSantha]

❌ Ticket runner: phase REVIEW failed after 3 retries.