Accept quoted URLs in image commands#169
Open
maxehmoon wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! However, if I see quotes being accepted, I would think that I can use spaces in the url and it would still be ok as it is quoted, which is not true. So we should probably think about how this is making it misleading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several members of my community have run into issues when creating image maps because they wrap the image URL in quotes, for example:
/imageframe create test "https://example.com/image.png" 1 1At the moment, those quote characters are passed through as part of the URL, which causes the image download to fail even though the link itself is valid.
This PR adds support for matching outer quotes around URL arguments. It only strips a single matching pair of leading/trailing single or double quotes, so normal URLs are unchanged and quote characters inside the URL are left intact.
This should make the command a little more forgiving for users who copy commands from examples, shells, or chat messages, without changing the expected behaviour for existing valid commands.