add missing operators and fix precedences#34
Merged
Conversation
SpaceManiac
reviewed
Jun 17, 2025
| GreaterEq(Box<Self>, Box<Self>), | ||
| // Arithmetic operators | ||
| /// `-a` | ||
| Neg(Box<Self>), |
Contributor
There was a problem hiding this comment.
Any particular reason to drop Neg? Wasm has a floating-point neg instruction, and integer neg is easy to implement as ~x + 1
Contributor
Author
There was a problem hiding this comment.
Mostly because it was previously ~, and when I changed that I removed it. But it probably makes sense to keep it I guess.
So I added it back. I'm not really sure how much people actually use the unary negation in general though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #32
I also fixed the operator precedences since the existing ones were just placeholders.