Skip to content

GH-481: [WORKFLOW] Fix deprecated apt-key in Neo4J Setup Test workflow#482

Merged
zaeema-n merged 3 commits into
LDFLK:mainfrom
zaeema-n:fix-deprecated-key-2
May 21, 2026
Merged

GH-481: [WORKFLOW] Fix deprecated apt-key in Neo4J Setup Test workflow#482
zaeema-n merged 3 commits into
LDFLK:mainfrom
zaeema-n:fix-deprecated-key-2

Conversation

@zaeema-n

Copy link
Copy Markdown
Member

This pr closes #481

@zaeema-n zaeema-n marked this pull request as draft May 21, 2026 05:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default READ_SERVICE_URL in the end-to-end tests from http://read:8081 to http://0.0.0.0:8081. Feedback indicates that using 0.0.0.0 as a destination address is semantically incorrect and non-portable, suggesting the use of 127.0.0.1 or localhost instead.

Comment thread opengin/tests/e2e/basic_core_tests.py
@zaeema-n zaeema-n marked this pull request as ready for review May 21, 2026 05:21
@zaeema-n zaeema-n requested a review from ChanukaUOJ May 21, 2026 05:21

@ChanukaUOJ ChanukaUOJ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zaeema-n zaeema-n merged commit 4e38160 into LDFLK:main May 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WORKFLOW] Fix deprecated apt-key in Neo4J Setup Test workflow

2 participants