GH : 443 | Invalidating attributes after the given startTime and endTime period

opengin/core-api/engine/attribute_resolver.go

@@ -131,8 +131,44 @@ func (p *EntityAttributeProcessor) ProcessEntityAttributes(ctx context.Context,
 			// Create or update graph metadata BEFORE processing the attribute
 			// NOTE: for the attribute the timestamp is always the value carried at the attribute level
 			// not the entity level. The entity level timestamp is used for the entity itself.
-			attributeStartTime, _ := time.Parse(time.RFC3339, value.StartTime)
-			if err := p.handleAttributeLookUp(ctx, entity.Id, attrName, storageType, operation, attributeStartTime); err != nil {
+
+			// start time is required to create the attribute
+			if operation != "read" && value.StartTime == "" {
+				attributeResults[attrName] = &Result{
+					Success: false,
+					Error:   fmt.Errorf("StartTime is required for attribute: %s", attrName),
+				}
+				continue
+			}
+			var attributeStartTime time.Time
+
+			if value.StartTime != "" {
+				attributeStartTime, err = time.Parse(time.RFC3339, value.StartTime)
+				if err != nil {
+					attributeResults[attrName] = &Result{
+						Success: false,
+						Error:   fmt.Errorf("invalid StartTime format for attribute %s: %v", attrName, err),
+					}
+					continue
+				}
+			}
+
+			var attributeEndTime *time.Time
+
+			if value.EndTime != "" {
+				t, err := time.Parse(time.RFC3339, value.EndTime)
+				if err != nil {
+					attributeResults[attrName] = &Result{
+						Success: false,
+						Error:   fmt.Errorf("invalid EndTime format for attribute %s: %v", attrName, err),
+					}
+					continue
+				}
+				attributeEndTime = &t
+			}
+
+
+			if err := p.handleAttributeLookUp(ctx, entity.Id, attrName, storageType, operation, attributeStartTime, attributeEndTime); err != nil {
 				attributeResults[attrName] = &Result{
 					Success: false,
 					Data:    nil,
@@ -196,7 +232,7 @@ func (p *EntityAttributeProcessor) ProcessEntityAttributes(ctx context.Context,
 // It creates the attribute look up metadata and the attribute node in the graph.
 // It also creates the IS_ATTRIBUTE relationship between the entity and the attribute.
 // It also creates the attribute metadata in the document database.
-func (p *EntityAttributeProcessor) handleAttributeLookUp(ctx context.Context, entityID, attrName string, storageType storageinference.StorageType, operation string, startTime time.Time) error {
+func (p *EntityAttributeProcessor) handleAttributeLookUp(ctx context.Context, entityID, attrName string, storageType storageinference.StorageType, operation string, startTime time.Time, endTime *time.Time) error {
 	// Generate attribute metadata
 	fmt.Printf("DEBUG: Handling graph metadata for attribute %s\n", attrName)
 	attributeID := GenerateAttributeID(entityID, attrName)
@@ -209,11 +245,13 @@ func (p *EntityAttributeProcessor) handleAttributeLookUp(ctx context.Context, en
 		StorageType:   storageType,
 		StoragePath:   storagePath,
 		Created:       startTime,
+		Terminated:    endTime,
 		Updated:       time.Now(),
 		Schema:        make(map[string]interface{}), // TODO: Extract schema from value
 	}
 
 	// Note: endTime parameter is optional and available for future use if needed
+	log.Printf("DEBUG: Handling graph metadata for attribute %s: [endTime: %v] [startTime: %v]", attrName, endTime, startTime)
 
 	switch operation {
 	case "create":

opengin/core-api/engine/graph_metadata_manager.go

@@ -56,7 +56,7 @@ type AttributeMetadata struct {
 	StoragePath   string // Path/location in the specific storage system
 	Created       time.Time
 	Updated       time.Time
-	EndTime       time.Time
+	Terminated    *time.Time
 	Schema        map[string]interface{} // Schema information
 }
 
@@ -126,6 +126,14 @@ func (g *GraphMetadataManager) createAttributeLookUpGraph(ctx context.Context, m
 
 	// create the attribute node in the graph
 	// stored parameters: id, kind, name, created
+	log.Printf("DEBUG: Creating attribute node for attribute %s: [endTime: %v] [startTime: %v]", metadata.AttributeName, metadata.Terminated, metadata.Created)
+
+	var terminated string
+
+	if metadata.Terminated != nil {
+		terminated = metadata.Terminated.Format(time.RFC3339)
+	}
+
 	attributeNode := &pb.Entity{
 		Id: metadata.AttributeID,
 		Kind: &pb.Kind{
@@ -134,7 +142,7 @@ func (g *GraphMetadataManager) createAttributeLookUpGraph(ctx context.Context, m
 		},
 		Name:          commons.CreateTimeBasedValue(metadata.Created.Format(time.RFC3339), "", metadata.AttributeName),
 		Created:       metadata.Created.Format(time.RFC3339), // contains the data object's time relation with the world
-		Terminated:    "",                                    // TODO: Implement invalidating a dataset for a specific time range
+		Terminated:    terminated,
 		Metadata:      MakeMetadataOfAttributeMetadata(metadata),
 		Attributes:    make(map[string]*pb.TimeBasedValueList),
 		Relationships: make(map[string]*pb.Relationship),
@@ -234,12 +242,16 @@ func MakeMetadataOfAttributeMetadata(metadata *AttributeMetadata) map[string]*an
 
 // MakeRelationshipProto creates a Relationship protobuf object for IS_ATTRIBUTE relationship
 func MakeRelationshipFromAttributeMetadata(metadata *AttributeMetadata) *pb.Relationship {
+	var endTime string
+	if metadata.Terminated != nil {
+		endTime = metadata.Terminated.Format(time.RFC3339)
+	}
 	return &pb.Relationship{
 		Id:              GenerateAttributeRelationshipID(metadata.EntityID, metadata.AttributeName),
 		RelatedEntityId: metadata.AttributeID,
 		Name:            IS_ATTRIBUTE_RELATIONSHIP,
 		StartTime:       metadata.Created.Format(time.RFC3339),
-		EndTime:         "", // TODO: Implement invalidating a relationship for a specific time range
+		EndTime:         endTime,
 		Direction:       IS_ATTRIBUTE_RELATIONSHIP_DIRECTION,
 	}
 }