Skip to content

spiral_2D_array now uses the center parameter#437

Merged
fakufaku merged 1 commit into
LCAV:masterfrom
robrui:fix/spiral-2d-array-center
May 17, 2026
Merged

spiral_2D_array now uses the center parameter#437
fakufaku merged 1 commit into
LCAV:masterfrom
robrui:fix/spiral-2d-array-center

Conversation

@robrui

@robrui robrui commented May 15, 2026

Copy link
Copy Markdown
Contributor

The spiral_2D_array function accepted a center parameter but didn't use it — the array was always returned at the origin. All other array generators (linear_2D_array, circular_2D_array, poisson_2D_array) add the center offset correctly, so this brings the spiral function in line.

Fixes #413.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@robrui robrui marked this pull request as ready for review May 15, 2026 03:38
@fakufaku

Copy link
Copy Markdown
Collaborator

Thanks for contributing! 🤗

@robrui

robrui commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Quick note on the CI failures — all 46 failing tests are in tests/directivities/ and trace back to a 403 from sofacoustics.org:

urllib.error.URLError: <urlopen error Failed to download http://sofacoustics.org/data/database/mit/mit_kemar_large_pinna.sofa>

The whole domain is returning 403, even the homepage. So unrelated to the spiral changes here. Might resolve on its own once the server is back up.

@fakufaku

Copy link
Copy Markdown
Collaborator

Thanks for following up. Your test is passing so I'll merge it and fix the CI later. 👍

@fakufaku fakufaku merged commit 6fe43fe into LCAV:master May 17, 2026
16 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spiral 2D array not using the center parameter

2 participants