spiral_2D_array now uses the center parameter#437
Merged
Conversation
Collaborator
|
Thanks for contributing! 🤗 |
Contributor
Author
|
Quick note on the CI failures — all 46 failing tests are in tests/directivities/ and trace back to a 403 from sofacoustics.org: The whole domain is returning 403, even the homepage. So unrelated to the spiral changes here. Might resolve on its own once the server is back up. |
Collaborator
|
Thanks for following up. Your test is passing so I'll merge it and fix the CI later. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
spiral_2D_arrayfunction accepted acenterparameter but didn't use it — the array was always returned at the origin. All other array generators (linear_2D_array,circular_2D_array,poisson_2D_array) add the center offset correctly, so this brings the spiral function in line.Fixes #413.
nosetestsorpy.testat the root of the repo ?